Skip to content

feat(protocol)!: adopt the signed AdCP 3.3.0-rc.0 bundle - #1919

Merged
bokelley merged 1 commit into
nextfrom
chore/adopt-adcp-3-3-0-rc-0
Nov 17, 2026
Merged

bokelley merged 1 commit into
nextfrom
chore/adopt-adcp-3-3-0-rc-0

Conversation

@bokelley

@bokelley bokelley commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Adopts the signed AdCP 3.3.0-rc.0 bundle, the first 3.3 release candidate, on the SDK 10 / next line. It follows #1901 (beta.6) and ships as the next 10.0.0 beta.

Pin

  • schemas/releases/3.3.0-rc.0.json records:
    • source commit 620b161718be, from the Fulcio certificate (the v3.3.0-rc.0 tag, b5ac0e1b, is its "Version Packages" child);
    • bundle sha256 bdcacb0bb548…, 27,800,935 bytes;
    • the .sig, .crt and .sha256 sidecars.
  • cosign verify-blob against release.yml@refs/heads/main prints Verified OK.
  • The CDN copy wasn't live yet, so the tree was synced from the verified GitHub release assets. A local driver checked the four assets against the pin byte for byte, re-ran the repo's own cosign verification, then called sync_schemas.py's own cache, skills, vector, compliance and patch functions.
  • The CDN copy went live at 03:17Z with the same bundle sha256. A strict sync_schemas.py --require-signed-release from the CDN, followed by fix_schema_refs.py, verified the checksum and exact signing identity and left the committed tree unchanged. (CI skips its CDN download and drift steps for a prerelease pin, so this local re-sync is the CDN check.)
  • The types were regenerated from the beta.6 tree, so SCHEMA_DELTAS.md is the full beta.6 → rc.0 delta.

What rc.0 changes, and what the SDK does

Spec change SDK
Three experimental values renamed with no alias (adcp#8901): input_required → input-required, click_through → clickthrough, underdelivery → under_delivery Generated. No hand-written code used the old spellings.
Reserved-word-safe replacements (adcp#8791): passed, all, full_name replace the deprecated pass, global, name; a replacement goes only to peers on 3.3 or later Generated. Version conversion now rewrites a replacement to the original it supersedes for an older peer. It reads x-superseded-by from the 3.3 schema's enumMetadata, so a 3.2 buyer gets pass, not a refusal. Untyped error.details (the RATE_LIMITED scope) isn't rewritten.
authorized_agents multi-match (adcp#8943, #9016) fetch_publisher_signing_pins now follows the rule. Every matching entry counts, the agent is pinned only if every one carries signing_keys, the pin is their union, and copies of a key keep the earliest revoked_at. This replaces the beta.6 "exact entry wins / exactly one" rule. It's evaluated per publisher domain; a message's narrower scope isn't.
creative.assignment_operations (adcp#8933) Generated. Sellers that accept assignment_operations must now declare them; this is noted in MIGRATION.
Audience targeting without inline push (#8936), social distribution identifiers, image_carousel cta_values, aligned submitted branches (#8856), governance human_review_required Generated. No hand-written code depends on them.

Fix the candidate exposed

ReportingService advertises a default supported_versions for subscriptions (#1771). It filtered out every release containing -rc, meant to drop the 3.2-rc.7 alias. With the packaged pin at 3.3-rc.0, that would have hidden the 3.3 line from buyers. It now leaves out only compatibility aliases.

Reporting vectors and storage contract

Not done (follow-ups)

  • Mapping all → global inside RATE_LIMITED error.details for 3.2 peers.
  • A buyer-side refusal of an assignment_operations entry the seller doesn't list.
  • A startup check that a compact-buy seller with a creative library lists assign.
  • Scope-aware signing-pin evaluation (property, window, country) below the publisher domain.

Breaking

  • The SDK speaks 3.3-rc.0 and no longer accepts 3.3-beta.6. get_supported_adcp_versions() is 3.0, 3.1, 3.2, 3.3-rc.0, 3.2-rc.7.
  • The three experimental values are renamed with no alias.
  • fetch_publisher_signing_pins returns the union of every matching entry's pins, or None when any matching entry is unpinned.

Recorded in MIGRATION_v9_to_v10.md and docs/adcp-3.3-sdk-inventory.md section 17.

Verification

  • make validate-generated and make lint pass.
  • make typecheck-all: every contract passes (mypy on 1,707 source files, adopter fixtures, pyright).
  • Full suite: 22,073 passed, 3,024 skipped. The one local failure, test_current_signed_compliance_bytes_ship_in_each_distribution, came from a stale gitignored build/lib left by the provisional dry run; after clearing it the module passes.
  • The adoption test pins the identity values: manifest 4,715 files, provenance 249 files and 1,767 schemas.
  • tests/test_reserved_word_replacements.py and tests/test_adagents_matching.py cover the new conversion and signing-pin behaviour.

BREAKING CHANGE: the SDK no longer advertises or accepts AdCP 3.3-beta.6. get_supported_adcp_versions is 3.0, 3.1, 3.2, 3.3-rc.0 and 3.2-rc.7; an adcp_version pin of 3.3-beta.6 or 3.3.0-beta.6 raises ConfigurationError, and a peer that advertises only 3.3-beta.6 for the 3.3 line negotiates down to 3.2. Re-pin to 3.3-rc.0 or omit the pin. The experimental values input_required, click_through and underdelivery are renamed with no alias, and fetch_publisher_signing_pins now returns the union of every matching entry's pins, or None when any matching entry is unpinned.

🤖 Generated with Claude Code

Pin src/adcp/ADCP_VERSION to 3.3.0-rc.0 from the audited, cosign-verified
release: schemas/releases/3.3.0-rc.0.json, source commit 620b161718be from
the Fulcio certificate (the tag is its Version Packages child), bundle sha256
bdcacb0bb548. Resync the schema cache, packaged compliance inputs,
request-signing vectors and skills, regenerate the types from the beta.6 tree
and the public API snapshot. The wheel ships the rc.0 schemas and compliance
tree; the beta.6 trees stay in the repository as history.

Renamed experimental values (adcp#8901), with no alias: input_required to
input-required in execution readiness, click_through to clickthrough in
creative change kinds, underdelivery to under_delivery in delivery
projections. Reserved-word-safe replacements (adcp#8791): passed for pass,
all for global, full_name for name. The originals stay valid through 3.x;
version conversion rewrites a replacement to the original it supersedes for
a peer below 3.3, reading x-superseded-by from the 3.3 schema.

authorized_agents multi-match (adcp#8943, #9016): every entry matching an
agent authorizes it, and fetch_publisher_signing_pins pins the agent only if
every matching entry carries signing_keys, as the union of their keys, with
the earliest revoked_at for copies of one key. This replaces the beta.6
exact-entry-wins rule.

SDK-hosted reporting advertised supported_versions without any "-rc"
release, which would have dropped the packaged 3.3-rc.0 itself; it now
leaves out only the compatibility aliases (3.2-rc.7).

Also generated: creative.assignment_operations (adcp#8933),
image_carousel cta_values, social distribution identifiers, the
audience_targeting capability split, campaign governance
human_review_required, and the aligned submitted branches.

BREAKING CHANGE: the SDK no longer advertises or accepts AdCP 3.3-beta.6.
get_supported_adcp_versions is 3.0, 3.1, 3.2, 3.3-rc.0 and 3.2-rc.7; an
adcp_version pin of 3.3-beta.6 or 3.3.0-beta.6 raises ConfigurationError,
and a peer that advertises only 3.3-beta.6 for the 3.3 line negotiates down
to 3.2. Re-pin to 3.3-rc.0 or omit the pin. The experimental values
input_required, click_through and underdelivery are renamed with no alias,
and fetch_publisher_signing_pins now returns the union of every matching
entry's pins, or None when any matching entry is unpinned.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — clean schema-adoption PR pinning AdCP 3.3.0-rc.0.

What I checked:

  • Decision table top-down: no critical/high/medium findings (rows 1, 4, 5, 8 don't fire). gated_paths is false (row 2 n/a). No (deleted) entries — all high-risk matches are (added) schema cache files (row 3 n/a). No prior decision (row 6 n/a). No no-auto-approve team match (row 7 n/a). Falls through to row 9 → approve.
  • high_risk: true is driven entirely by newly-added schemas/** cache files (added) — per arbiter guidance, a PR that only adds new files matching high-risk globs is normal scaffolding, not escalation-worthy on the flag alone.
  • Semver signal is correct: the breaking surface (3.3-beta.6 no longer accepted, three experimental enum renames with no alias, fetch_publisher_signing_pins return-shape change) carries feat(protocol)! + a BREAKING CHANGE footer and migration notes.
  • Hand-written logic changes reviewed and test-covered: adagents.py signing-pin merge is fail-closed; compat/versions.py superseded-enum passthrough is correct; reporting/service.py supported_versions filter has the right shape. Forward-compat unions, aliases.py, _ergonomic.py untouched; _generated.py change is regen output.

No blocking or medium findings.

@bokelley
bokelley merged commit 2f46153 into next Nov 17, 2026
41 checks passed
@bokelley
bokelley deleted the chore/adopt-adcp-3-3-0-rc-0 branch November 17, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant